Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): fix types for eslint-utils #4173

Merged

Conversation

roikoren755
Copy link
Contributor

PR Checklist

Overview

Fixed typings for ReferenceTracker, getFunctionNameWithKind and getPropertyName, re-exported from eslint-utils.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @roikoren755!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: d63020b

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6194e5e37a38f50007410ac1

😎 Browse the preview: https://deploy-preview-4173--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #4173 (d63020b) into master (5a326e4) will decrease coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4173      +/-   ##
==========================================
- Coverage   93.36%   92.70%   -0.66%     
==========================================
  Files         152      194      +42     
  Lines        8047     8678     +631     
  Branches     2584     2691     +107     
==========================================
+ Hits         7513     8045     +532     
- Misses        179      254      +75     
- Partials      355      379      +24     
Flag Coverage Δ
unittest 92.70% <100.00%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ils/src/ast-utils/eslint-utils/ReferenceTracker.ts 100.00% <ø> (ø)
...l-utils/src/ast-utils/eslint-utils/astUtilities.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 93.33% <100.00%> (+0.31%) ⬆️
...-utils/src/ast-utils/eslint-utils/scopeAnalysis.ts 100.00% <0.00%> (ø)
...xperimental-utils/src/eslint-utils/applyDefault.ts 100.00% <0.00%> (ø)
...ackages/experimental-utils/src/ts-eslint/ESLint.ts 50.00% <0.00%> (ø)
.../experimental-utils/src/eslint-utils/RuleTester.ts 9.30% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 91.30% <0.00%> (ø)
...es/experimental-utils/src/ts-eslint-scope/Scope.ts 100.00% <0.00%> (ø)
... and 35 more

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong types for eslint-utils' ReferenceTracker
2 participants