Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): add default [] for RuleModule TOptions generic #4135

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Allow TOptions to default to [] so there's less overhead in setting up rules. Related to #4124.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 13, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 5220f4b

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/619005f407003d0007e8465f

😎 Browse the preview: https://deploy-preview-4135--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #4135 (5220f4b) into master (ae0fb5a) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
- Coverage   93.35%   93.14%   -0.22%     
==========================================
  Files         152      157       +5     
  Lines        8035     8251     +216     
  Branches     2579     2640      +61     
==========================================
+ Hits         7501     7685     +184     
- Misses        180      192      +12     
- Partials      354      374      +20     
Flag Coverage Δ
unittest 93.14% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/no-confusing-non-null-assertion.ts 82.60% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 93.50% <ø> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts 90.00% <ø> (ø)
...plugin/src/rules/prefer-string-starts-ends-with.ts 97.83% <ø> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.48% <100.00%> (+0.02%) ⬆️
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <0.00%> (ø)
...internal/src/rules/no-typescript-default-import.ts 100.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 81.34% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts 87.50% <0.00%> (ø)
... and 1 more

@bradzacher bradzacher added the enhancement New feature or request label Nov 14, 2021
@bradzacher bradzacher changed the title feat: add default [] for RuleModule TOptions generic feat(experimental-utils): add default [] for RuleModule TOptions generic Nov 14, 2021
@bradzacher bradzacher merged commit 62b8098 into typescript-eslint:master Nov 14, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the rule-module-options-default branch November 14, 2021 04:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow generic defaults for TSESLint.RuleModule?
2 participants