Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: landing page title duplication #4123

Merged
merged 2 commits into from Nov 11, 2021
Merged

fix: landing page title duplication #4123

merged 2 commits into from Nov 11, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Fixes the config to not have a space, and removes the redundant title from the landing page.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 11, 2021 •
edited

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: c896d60

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618d530252da910007c74129

😎 Browse the preview: https://deploy-preview-4123--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Nov 11, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit c896d60. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@armano2 armano2 self-requested a review November 11, 2021 16:51
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 11, 2021 17:29
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Nov 11, 2021
@bradzacher bradzacher changed the title fix: landing page title duplication docs: landing page title duplication Nov 11, 2021
@bradzacher bradzacher changed the title docs: landing page title duplication docs: fix landing page title duplication Nov 11, 2021
@bradzacher bradzacher changed the title docs: fix landing page title duplication fix: landing page title duplication Nov 11, 2021
@bradzacher bradzacher merged commit 844c25e into typescript-eslint:master Nov 11, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the landing-page-title branch November 11, 2021 17:45
This was referenced Nov 16, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 23, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: website landing page title is "TypeScript ESLint | TypeScript ESLint "
3 participants
@JoshuaKGoldberg @armano2 @bradzacher