Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experimental-utils): add name property to test case interface #4067

Merged
merged 1 commit into from Oct 30, 2021
Merged

fix(experimental-utils): add name property to test case interface #4067

merged 1 commit into from Oct 30, 2021

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 28, 2021

PR Checklist

Overview

I implemented this in ESLint.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@G-Rath G-Rath changed the title fix(eslint-plugin): add name property to test case interface fix(utils): add name property to test case interface Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited

Codecov Report

Merging #4067 (4ca5ae3) into master (9c8f9a8) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4067      +/-   ##
==========================================
- Coverage   93.07%   92.65%   -0.42%     
==========================================
  Files         295      194     -101     
  Lines       11069     8630    -2439     
  Branches     3218     2675     -543     
==========================================
- Hits        10302     7996    -2306     
+ Misses        299      256      -43     
+ Partials      468      378      -90
Flag Coverage Δ
unittest 92.65% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.proxy.ts
packages/scope-manager/src/scope/SwitchScope.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/ast-converter.ts
packages/scope-manager/src/lib/es2015.core.ts
packages/scope-manager/src/scope/TypeScope.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
...ges/scope-manager/src/lib/es2018.asyncgenerator.ts
packages/scope-manager/src/lib/es2017.object.ts
... and 166 more

@nx-cloud
Copy link

nx-cloud bot commented Oct 28, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 4ca5ae3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Oct 28, 2021

Nx Cloud Report

CI ran the following commands for commit 4ca5ae3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys
#000000 Node 16.x - nx test @typescript-eslint/visitor-keys
#000000 Node 14.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx run-many --target=build --all --parallel

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @G-Rath!

@bradzacher bradzacher added the bug Something isn't working label Oct 30, 2021
@bradzacher bradzacher changed the title fix(utils): add name property to test case interface fix(experimental-utils): add name property to test case interface Oct 30, 2021
@bradzacher bradzacher merged commit f3021c9 into typescript-eslint:master Oct 30, 2021
@G-Rath G-Rath deleted the add-name-property branch October 30, 2021 23:18
This was referenced Nov 2, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Add "test name" option to ValidTestCase / InvalidTestCase
3 participants
@G-Rath @JoshuaKGoldberg @bradzacher