Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [padding-line-between-statements] TSModuleBlock should change scope #3944

Merged
merged 3 commits into from Oct 3, 2021

Conversation

josephzidell
Copy link
Contributor

Updates the scope changes to include TSModuleBlock. This helps a module declaration be its own scope, thereby fixing false positives related to #3869

Updates the scope changes to include `TSModuleBlock`. This helps a `module` declaration be its own scope, thereby fixing false positives related to #3869
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @josephzidell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Updates the test to expect 3 errors
Removes an unnecessary trailing blank line
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #3944 (b66073f) into master (02c6ff3) will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3944      +/-   ##
==========================================
+ Coverage   92.70%   93.51%   +0.81%     
==========================================
  Files         331      151     -180     
  Lines       11637     8143    -3494     
  Branches     3290     2582     -708     
==========================================
- Hits        10788     7615    -3173     
+ Misses        371      167     -204     
+ Partials      478      361     -117     
Flag Coverage Δ
unittest 93.51% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/padding-line-between-statements.ts 91.09% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts
packages/scope-manager/src/lib/es6.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
packages/experimental-utils/src/json-schema.ts
...ackages/experimental-utils/src/ts-eslint/Linter.ts
.../experimental-utils/src/ts-eslint-scope/analyze.ts
packages/scope-manager/src/lib/esnext.weakref.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
packages/scope-manager/src/lib/es2015.proxy.ts
... and 171 more

@bradzacher bradzacher added the bug Something isn't working label Oct 3, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for being a champion and fixing this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants