fix(eslint-plugin): [consistent-type-definitions] correct fix for export default

[rafaelss95]

Fixes #3894.

[typescript-eslint]

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #3899 (1e7e6d8) into master (b1df817) will increase coverage by 0.81%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #3899      +/-   ##
==========================================
+ Coverage   92.70%   93.52%   +0.81%     
==========================================
  Files         329      149     -180     
  Lines       11534     8046    -3488     
  Branches     3257     2552     -705     
==========================================
- Hits        10693     7525    -3168     
+ Misses        368      164     -204     
+ Partials      473      357     -116     

Flag	Coverage Δ
unittest	93.52% <66.66%> (+0.81%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts	89.18% <66.66%> (-1.99%)	⬇️
...perimental-utils/src/ts-eslint-scope/Referencer.ts
packages/eslint-plugin-tslint/src/rules/config.ts
packages/scope-manager/src/referencer/Visitor.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
packages/typescript-estree/src/version-check.ts
packages/scope-manager/src/lib/es2019.object.ts
...ages/scope-manager/src/lib/es2016.array.include.ts
packages/scope-manager/src/scope/TSModuleScope.ts
...xperimental-utils/src/ts-eslint-scope/Reference.ts
... and 171 more

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 1e7e6d8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx run-many --target=typecheck --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/typescript-estree
	nx test @typescript-eslint/visitor-keys
	nx run-many --target=build --all --parallel
	nx test @typescript-eslint/typescript-estree
	nx run-many --target=build --all --parallel

---

Sent with 💌 from NxCloud.

[rafaelss95]

While working on this fix, I noticed that the option is checked after having already found a certain node (and in some other files as well), for example:

typescript-eslint/packages/eslint-plugin/src/rules/consistent-type-definitions.ts

Lines 50 to 54 in 1e7e6d8

	return {
	"TSTypeAliasDeclaration[typeAnnotation.type='TSTypeLiteral']"(
	node: TSESTree.TSTypeAliasDeclaration,
	): void {
	if (option === 'interface') {

Other cases I found _{(click to expand)}

typescript-eslint/packages/eslint-plugin/src/rules/method-signature-style.ts

Lines 120 to 123 in b1d4449

	TSMethodSignature(methodNode): void {
	if (mode === 'method') {
	return;
	}

typescript-eslint/packages/eslint-plugin/src/rules/restrict-plus-operands.ts

Lines 136 to 137 in 1c1b572

	"AssignmentExpression[operator='+=']"(node): void {
	if (checkCompoundAssignments) {

typescript-eslint/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts

Lines 242 to 244 in 25ea953

	return {
	TSIntersectionType(node): void {
	if (checkIntersections === true) {

typescript-eslint/packages/eslint-plugin/src/rules/typedef.ts

Lines 180 to 183 in 1c1b572

	'FunctionDeclaration, FunctionExpression'(
	node: TSESTree.FunctionDeclaration | TSESTree.FunctionExpression,
	): void {
	if (options[OptionKeys.Parameter]) {

typescript-eslint/packages/eslint-plugin/src/rules/explicit-function-return-type.ts

Lines 71 to 76 in 1c1b572

	return {
	'ArrowFunctionExpression, FunctionExpression'(
	node: TSESTree.ArrowFunctionExpression | TSESTree.FunctionExpression,
	): void {
	if (
	options.allowConciseArrowFunctionExpressionsStartingWithVoid &&

But, IMHO this could be improved by either moving the conditional up then wrapping the return { or, in some cases do ...(optionX && { node ... }), and so avoiding looking for nodes which doesn't corresponds unnecessarily. Does it makes sense for you? If so, I can send a PR refactor for that.

[bradzacher]

happy to accept a PR if you want!

[bradzacher]

thanks for fixing this!