fix(eslint-plugin): [dot-notation] false positive with optional chaining

[djcsdy]

fixes #3510

[typescript-eslint]

Thanks for the PR, @djcsdy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #3711 (7756865) into master (4d3ae13) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
+ Coverage   92.68%   93.57%   +0.89%     
==========================================
  Files         327      147     -180     
  Lines       11351     7864    -3487     
  Branches     3201     2490     -711     
==========================================
- Hits        10521     7359    -3162     
+ Misses        369      161     -208     
+ Partials      461      344     -117     

Flag	Coverage Δ
unittest	93.57% <100.00%> (+0.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/dot-notation.ts	92.30% <100.00%> (ø)
packages/scope-manager/src/referencer/Reference.ts
...ackages/scope-manager/src/scope/MappedTypeScope.ts
...cope-manager/src/definition/ClassNameDefinition.ts
packages/experimental-utils/src/ts-eslint/Scope.ts
packages/scope-manager/src/lib/es2015.symbol.ts
packages/scope-manager/src/scope/FunctionScope.ts
...s/experimental-utils/src/eslint-utils/deepMerge.ts
...ages/scope-manager/src/referencer/ImportVisitor.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
... and 171 more

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 7756865. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx run-many --target=typecheck --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/typescript-estree
	nx test @typescript-eslint/experimental-utils
	nx run-many --target=build --all --parallel
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/typescript-estree
	nx run-many --target=build --all --parallel

---

Sent with 💌 from NxCloud.

[bradzacher]

thanks for fixing this!