Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript-estree): correct tty check #3635

Merged
merged 2 commits into from Aug 1, 2021
Merged

fix(typescript-estree): correct tty check #3635

merged 2 commits into from Aug 1, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jul 14, 2021

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 14, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 6dd5abc. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@bradzacher bradzacher changed the title fix: typeof results undefined string fix(typescript-estree): correct tty check Jul 31, 2021
bradzacher
bradzacher approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow.. how has this existed for so long without anyone noticing...?
thanks for fixing this!

@bradzacher bradzacher merged commit 62bcc93 into typescript-eslint:master Aug 1, 2021
@JounQin JounQin deleted the patch-1 branch August 1, 2021 01:42
@JounQin
Copy link
Contributor Author

JounQin commented Aug 1, 2021

I found it at https://lgtm.com/projects/g/typescript-eslint/typescript-eslint?mode=list

@JounQin JounQin mentioned this pull request Aug 30, 2021
Closed
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JounQin @MichaelDeBoey @bradzacher