Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): make keys for ReferenceTracker options optional #3531

Merged
merged 1 commit into from Jun 17, 2021
Merged

fix(experimental-utils): make keys for ReferenceTracker options optional #3531

merged 1 commit into from Jun 17, 2021

Conversation

MageJohn
Copy link
Contributor

Fixes #3526

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MageJohn!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jun 15, 2021

Nx Cloud Report

CI ran the following commands for commit 1a0f33c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@MageJohn
Copy link
Contributor Author

Not sure how to resolve the Semantic Pull Request failure; let me know and I'll get it done!

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher added the bug Something isn't working label Jun 17, 2021
@bradzacher bradzacher changed the title fix(experimental-utils): Make keys for ReferenceTracker options optional fix(experimental-utils): make keys for ReferenceTracker options optional Jun 17, 2021
@bradzacher bradzacher merged commit a7fd7bb into typescript-eslint:master Jun 17, 2021
@MageJohn MageJohn deleted the experimental-utils/ReferenceTracker-optional-options branch June 17, 2021 10:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The keys in the options argument to ReferenceTracker should be optional
2 participants