feat(ast-spec): specify PunctuatorToken's value type

[MichaelDeBoey]

As discussed in #3461 (comment)

---

This is technically a breaking change, but ast-spec is never published, so we shouldn't care I think.

CC/ @bradzacher

[typescript-eslint]

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[MichaelDeBoey]

@bradzacher Looking at the error, I don't really know how to fix it tbh.
Can you point me into the right direction please?

[MichaelDeBoey]

@bradzacher @JamesHenry Is there anything I still need to do for this one?

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit edb5087. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx run-many --target=build --all --parallel
	nx run-many --target=typecheck --all --parallel

---

Sent with 💌 from NxCloud.

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 71aba31. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx run-many --target=build --all --parallel
	nx run-many --target=typecheck --all --parallel

---

Sent with 💌 from NxCloud.

[bradzacher]

Ideally I wouldn't want us to have to keep track of this 60 element union ourselves AND duplicate it into a separate interface map PunctuatorTokenToText or other.

So if you can refactor the types so that we have

• PunctuatorTokenToText,
• TokenToText extends PunctuatorTokenToText, and
• PunctuatorToken['value'] === values<PunctuatorTokenToText>

I'm all for that approach

[MichaelDeBoey]

@bradzacher Where do you want me to have PunctuatorTokenToText to live then?
TokenToText is living in typescript-estree and ast-spec currently doesn't have any dependencies

[bradzacher]

ast-spec is not a published package. It is built and copied across to the types package.
So we don't care if we add dependencies to it.

As long as you explicitly mark the TS import as an import type then it should be built and copied fine.

You can add this block to the types package.json to ensure we have an implicit peer dependency on it.

typescript-eslint/packages/typescript-estree/package.json

Lines 69 to 73 in b15a2b2

	"peerDependenciesMeta": {
	"typescript": {
	"optional": true
	}
	},

[MichaelDeBoey]

@bradzacher Just pushed the commits you asked for.

I'm happy to change some things around if needed.

[bradzacher]

lgtm - thanks for this!

[MichaelDeBoey]

Always happy to help out!