Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope-manager): reduce generated lib file size #3468

Merged
merged 1 commit into from May 30, 2021

Conversation

bradzacher
Copy link
Member

The old generation strategy was verbose and thus generated a lot of duplicated code.
I figured that we can pretty easily reduce this down significantly, which will reduce the package size and make some repo operations faster as we're not loading very large files.

before:

$ du -sh packages/scope-manager/src/lib
560K    packages/scope-manager/src/lib
$ ls -lS packages/scope-manager/src/lib
total 1120
207246 dom.ts
 64783 webworker.ts
 15282 es5.ts
  8238 dom.iterable.ts
  6714 es2015.iterable.ts
  5352 index.ts
  4962 es2015.symbol.wellknown.ts
  2472 webworker.iterable.ts
  2189 scripthost.ts
  2031 es2015.core.ts
  1874 es2016.array.include.ts
  1786 es2017.typedarrays.ts
  1715 es2015.collection.ts
  1651 es2020.bigint.ts
  1651 esnext.bigint.ts
  1067 es2017.sharedmemory.ts
  1038 es2018.asynciterable.ts
  1038 esnext.asynciterable.ts
   970 es2015.ts
   967 es6.ts
   922 es2020.promise.ts
   910 es2021.weakref.ts
   910 esnext.weakref.ts
   871 es2018.asyncgenerator.ts
   821 es2015.generator.ts
   763 es2020.ts
   749 es2021.promise.ts
   749 esnext.promise.ts
   711 es2020.symbol.wellknown.ts
   709 es2018.regexp.ts
   691 es2018.ts
   688 es2019.array.ts
   688 esnext.array.ts
   676 es2017.ts
   577 es2019.ts
   573 es2016.full.ts
   573 es2017.full.ts
   573 es2018.full.ts
   573 es2019.full.ts
   573 es2020.full.ts
   573 es2021.full.ts
   573 esnext.full.ts
   566 es2015.proxy.ts
   517 es2021.ts
   496 es2019.object.ts
   490 lib.ts
   474 es2020.string.ts
   424 es2015.promise.ts
   421 es2015.symbol.ts
   421 es2017.object.ts
   407 es2020.sharedmemory.ts
   402 es2018.promise.ts
   401 es2015.reflect.ts
   399 es2017.string.ts
   399 es2019.string.ts
   399 es2019.symbol.ts
   399 es2021.string.ts
   399 esnext.string.ts
   399 esnext.symbol.ts
   394 es2016.ts
   392 es2017.intl.ts
   392 es2018.intl.ts
   392 es2020.intl.ts
   392 esnext.intl.ts
   391 es7.ts
   367 esnext.ts
   278 webworker.importscripts.ts

after:

$ du -sh packages/scope-manager/src/lib
320K    packages/scope-manager/src/lib
$ ls -lS packages/scope-manager/src/lib                               
total 640
40015 dom.ts
12109 webworker.ts
 5352 index.ts
 2806 es5.ts
 1584 dom.iterable.ts
 1378 es2015.iterable.ts
 1026 es2015.symbol.wellknown.ts
  970 es2015.ts
  967 es6.ts
  763 es2020.ts
  691 es2018.ts
  680 webworker.iterable.ts
  676 es2017.ts
  631 scripthost.ts
  607 es2017.sharedmemory.ts
  597 es2017.typedarrays.ts
  577 es2019.ts
  573 es2016.full.ts
  573 es2017.full.ts
  573 es2018.full.ts
  573 es2019.full.ts
  573 es2020.full.ts
  573 es2021.full.ts
  573 esnext.full.ts
  565 es2020.bigint.ts
  565 esnext.bigint.ts
  560 es2015.core.ts
  556 es2018.asynciterable.ts
  556 esnext.asynciterable.ts
  547 es2015.collection.ts
  538 es2016.array.include.ts
  529 base-config.ts
  517 es2021.ts
  498 es2018.asyncgenerator.ts
  498 es2020.symbol.wellknown.ts
  490 lib.ts
  463 es2015.generator.ts
  442 es2021.weakref.ts
  442 esnext.weakref.ts
  423 es2020.promise.ts
  407 es2021.promise.ts
  407 esnext.promise.ts
  403 es2019.object.ts
  394 es2016.ts
  392 es2020.string.ts
  391 es7.ts
  368 es2018.regexp.ts
  367 esnext.ts
  357 es2019.array.ts
  357 esnext.array.ts
  348 es2015.proxy.ts
  331 es2015.reflect.ts
  330 es2015.promise.ts
  328 es2015.symbol.ts
  328 es2017.object.ts
  325 es2017.intl.ts
  325 es2018.intl.ts
  325 es2020.intl.ts
  325 esnext.intl.ts
  324 es2020.sharedmemory.ts
  319 es2018.promise.ts
  317 es2017.string.ts
  317 es2019.string.ts
  317 es2019.symbol.ts
  317 es2021.string.ts
  317 esnext.string.ts
  317 esnext.symbol.ts
  278 webworker.importscripts.ts

The old generation strategy was verbose and thus generated a lot of duplicated code.
I figured that we can pretty easily reduce this down significantly, which will reduce the package size and make some repo operations faster as we're not loading 500kb files.

before:
```bash
$ du -sh packages/scope-manager/src/lib
560K    packages/scope-manager/src/lib
```
after:
```bash
$ du -sh packages/scope-manager/src/lib
320K    packages/scope-manager/src/lib
```
@bradzacher bradzacher added the enhancement New feature or request label May 30, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #3468 (9db0d9b) into master (d4f0774) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3468      +/-   ##
==========================================
+ Coverage   92.62%   92.66%   +0.03%     
==========================================
  Files         323      324       +1     
  Lines       11139    11189      +50     
  Branches     3158     3158              
==========================================
+ Hits        10318    10368      +50     
  Misses        365      365              
  Partials      456      456              
Flag Coverage Δ
unittest 92.66% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
packages/scope-manager/src/scope/GlobalScope.ts 94.73% <ø> (ø)
.../scope-manager/src/variable/ImplicitLibVariable.ts 50.00% <ø> (ø)
packages/scope-manager/src/lib/base-config.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <100.00%> (ø)
...ackages/scope-manager/src/lib/es2015.collection.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2015.core.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2015.generator.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2015.iterable.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2015.promise.ts 100.00% <100.00%> (ø)
... and 43 more

@bradzacher bradzacher merged commit 258116b into master May 30, 2021
@bradzacher bradzacher deleted the reduce-generated-lib-size branch May 30, 2021 19:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant