Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): fix eslint-utils' negative predicates' return types #3462

Merged
merged 1 commit into from Jun 17, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

Just like it's done with ast-utils' isNotCommentToken

const isNotCommentToken = eslintUtils.isNotCommentToken as (
token: TSESTree.Token,
) => token is Exclude<TSESTree.Token, TSESTree.Comment>;

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@MichaelDeBoey MichaelDeBoey force-pushed the patch-9 branch 2 times, most recently from ee0c751 to 6a9962a Compare June 4, 2021 17:11
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jun 4, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-9 branch 3 times, most recently from 3434e29 to 9e4bfce Compare June 12, 2021 11:56
@nx-cloud
Copy link

nx-cloud bot commented Jun 12, 2021

Nx Cloud Report

CI ran the following commands for commit 6c1d050. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Jun 12, 2021

Nx Cloud Report

CI ran the following commands for commit 9e4bfce. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@MichaelDeBoey
Copy link
Contributor Author

@bradzacher Now that #3496 is merged, this one can be merged too I think?

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 1e6016b into typescript-eslint:master Jun 17, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-9 branch June 17, 2021 08:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants