Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-regexp-exec] factor in union types #3434

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 23, 2021

Fixes #3319.

Edit 5/31: the tests were previously asserting on non-string (e.g. number) values getting a rule complaint... but that seems off? TypeScript should let us know anyway that /abc/.match(null) isn't allowed. Updated the logic to not report on them.

Co-authored-by: @IllusionMH

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #3434 (f03a4a4) into master (b3ac5f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3434   +/-   ##
=======================================
  Coverage   92.63%   92.64%           
=======================================
  Files         325      325           
  Lines       11235    11247   +12     
  Branches     3168     3169    +1     
=======================================
+ Hits        10408    10420   +12     
  Misses        367      367           
  Partials      460      460           
Flag Coverage Δ
unittest 92.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts 100.00% <100.00%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 23, 2021 13:53
@bradzacher bradzacher added the bug Something isn't working label May 24, 2021
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label May 28, 2021
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 1, 2021
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 6, 2021
@nx-cloud
Copy link

nx-cloud bot commented Jun 17, 2021

Nx Cloud Report

CI ran the following commands for commit f03a4a4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 20, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@bradzacher bradzacher merged commit ac86a79 into typescript-eslint:master Jun 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-regexp-exec-union-types branch November 17, 2021 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-regexp-exec] False positive for union types
2 participants