New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [prefer-regexp-exec] factor in union types #3434
fix(eslint-plugin): [prefer-regexp-exec] factor in union types #3434
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3434 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 325 325
Lines 11235 11247 +12
Branches 3168 3169 +1
=======================================
+ Hits 10408 10420 +12
Misses 367 367
Partials 460 460
Flags with carried forward coverage won't be shown. Click here to find out more.
|
89ab7ac
to
c79e813
Compare
Nx Cloud ReportCI ran the following commands for commit f03a4a4. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Fixes #3319.
Edit 5/31: the tests were previously asserting on non-
string
(e.g.number
) values getting a rule complaint... but that seems off? TypeScript should let us know anyway that/abc/.match(null)
isn't allowed. Updated the logic to not report on them.Co-authored-by: @IllusionMH