New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): add extension rule padding-line-between-statements
#3418
feat(eslint-plugin): add extension rule padding-line-between-statements
#3418
Conversation
Thanks for the PR, @yasarsid! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
========================================
Coverage 92.66% 92.66%
========================================
Files 324 328 +4
Lines 11188 11497 +309
Branches 3157 3252 +95
========================================
+ Hits 10367 10654 +287
- Misses 365 371 +6
- Partials 456 472 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ipt-eslint into padding-line-between-statments
…asarsid/typescript-eslint into padding-line-between-statments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no tests for any TS code.
So it looks like you haven't actually enhanced anything in the rule.
this PR must make changes to the rule to support TS syntax, or else there's no point in extending it.
packages/eslint-plugin/src/rules/padding-line-between-statements.ts
Outdated
Show resolved
Hide resolved
…into padding-line-between-statments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this - a few comments, but otherwise LGTM.
Thanks for all your work on this!
packages/eslint-plugin/src/rules/padding-line-between-statements.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/padding-line-between-statements.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/padding-line-between-statements.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
padding-line-between-statements
Fixes #2293
Overview
Add an extension rule for padding-line-between-statements so that we start supporting basic scenarios for it.
Link to the rule code in ESLint can be found here