New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [space-infix-ops] Add support for Union and intersection of type declarations #3360
feat(eslint-plugin): [space-infix-ops] Add support for Union and intersection of type declarations #3360
Conversation
Thanks for the PR, @doumart! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
ff7c667
to
c7841fc
Compare
I would just try reverting the changes to the lock file. |
Will hopefully resolve #51 |
6e61468
to
2bfe856
Compare
Codecov Report
@@ Coverage Diff @@
## master #3360 +/- ##
==========================================
- Coverage 92.67% 92.65% -0.02%
==========================================
Files 318 318
Lines 11109 11116 +7
Branches 3155 3157 +2
==========================================
+ Hits 10295 10300 +5
- Misses 362 363 +1
- Partials 452 453 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2e35a88
to
338b23f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good so far! The logic looks sound. A few small comments.
Please add some negative tests for things like
const x: string&number;
class Test {
value: string&number;
}
function foo<T extends string&number>() {}
function bar(): string&number {}
bc79357
to
63f5658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
How can I disable this rule from adding a space to my union types? There seems to be no config for it. Thanks |
Second PR so maybe i'm missing something. I added support for Union and Intersection of interface and type declarations.
There is the yarn.lock that was updated and don't understand why, i can remove it if it not support to be there