Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): fix visiting TSAsExpression in assignment #3355

Merged
merged 1 commit into from May 9, 2021
Merged

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented May 6, 2021

fixes #3336

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3355 (62d37c2) into master (ddfab95) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3355   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         318      318           
  Lines       11048    11048           
  Branches     3128     3128           
=======================================
  Hits        10259    10259           
  Misses        352      352           
  Partials      437      437           
Flag Coverage Δ
unittest 92.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts 93.90% <100.00%> (ø)

@yeonjuan yeonjuan changed the title fix(scope-manager): fix to use visitType for type node fix(scope-manager): fix visiting TSAsExpression in assignment May 6, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!
thanks for this!

@bradzacher bradzacher merged commit 87521a0 into typescript-eslint:master May 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no-undef" rules not recognizing definition 2 lines above
2 participants