Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [member-ordering] add callback as an ordering type of node #3354

Merged

Conversation

tanohzana
Copy link
Contributor

@tanohzana tanohzana commented May 6, 2021

Fixes #3037

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tanohzana!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3354 (56e66f9) into master (ddfab95) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
- Coverage   92.85%   92.61%   -0.25%     
==========================================
  Files         318      318              
  Lines       11048    11111      +63     
  Branches     3128     3155      +27     
==========================================
+ Hits        10259    10290      +31     
- Misses        352      365      +13     
- Partials      437      456      +19     
Flag Coverage Δ
unittest 92.61% <100.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 92.96% <100.00%> (-5.45%) ⬇️
packages/eslint-plugin/src/rules/no-shadow.ts 76.61% <0.00%> (-17.44%) ⬇️
packages/eslint-plugin/src/util/types.ts 81.18% <0.00%> (-0.69%) ⬇️
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 98.24% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 85.22% <0.00%> (ø)
...ges/experimental-utils/src/ast-utils/predicates.ts 36.84% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 92.96% <0.00%> (ø)
packages/typescript-estree/src/convert.ts 98.26% <0.00%> (+0.02%) ⬆️
packages/eslint-plugin/src/rules/dot-notation.ts 92.59% <0.00%> (+8.38%) ⬆️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label May 9, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't done a review yet - just a quick comment.
callback is the wrong name for this - as it's not a passed function or anything.

This is a call signature declaration, so the option should be called call-signature

ideally the other "signature" should really be index-signature, but that's a breaking change...

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label May 9, 2021
@tanohzana
Copy link
Contributor Author

@bradzacher I have changed the callback type to call-signature 🙂 Thanks for your comment

@tanohzana tanohzana requested a review from bradzacher May 27, 2021 09:05
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 27, 2021
@bradzacher bradzacher changed the title feat(eslint-plugin): add callback as an ordering type of node feat(eslint-plugin): [member-ordering] add callback as an ordering type of node May 28, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution!

@bradzacher bradzacher merged commit d134b1f into typescript-eslint:master May 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[member-ordering] feature request: differentiate methods and callback signatures
2 participants