Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): Include getCwd() in RuleContext type #3308

Merged
merged 2 commits into from May 9, 2021

Conversation

fa93hws
Copy link
Contributor

@fa93hws fa93hws commented Apr 23, 2021

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fa93hws!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@fa93hws fa93hws changed the title type: Include getCwd() in RuleContext feat: Include getCwd() in RuleContext Apr 23, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!
because we support <v6.6.0 we need to mark it as optional.

packages/experimental-utils/src/ts-eslint/Rule.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party enhancement New feature or request labels Apr 23, 2021
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@fa93hws fa93hws requested a review from bradzacher April 23, 2021 01:40
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 9, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher changed the title feat: Include getCwd() in RuleContext feat(experimental-utils): Include getCwd() in RuleContext type May 9, 2021
@bradzacher bradzacher merged commit 2b75c11 into typescript-eslint:master May 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants