fix(eslint-plugin): [no-unsafe-argument] handle tuple types on rest arguments #3269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@G-Rath noticed that we were false-reporting on jest expect functions.
Turns out this was because I hadn't handled tuple rest types.
It turns out that generic array rest types are reported by TS as if they were tuples.
So for
function foo<T extends any[]>(...param: T): void
-param
will always report as a tuple.Eg
foo(1, 2, 'a', 1 as any)
will report the type ofparam
to be[number, number, string, any]
. Which means we can't actually do a check here 😢