Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [space-infix-ops] support for class properties and type aliases #3231

Conversation

FDIM
Copy link
Contributor

@FDIM FDIM commented Mar 27, 2021

Hey,

I've bumped into this issue after migrating to eslint. Nice work btw! We've used whitespace rule in tslint for certain formatting and this PR will bring feature parity closer to what was there before. I know it's about whitespace, but moving to prettier is just too much for our code base and the patterns we are used to. Maybe one day :) (plenty of things gets far less readable)

Fixes #1699

A bit later I'll also have a look at #1606

EDIT:
2nd commit fixes first part of #1606

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @FDIM!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #3231 (394922b) into master (d0d7186) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3231      +/-   ##
==========================================
+ Coverage   92.90%   92.92%   +0.02%     
==========================================
  Files         316      316              
  Lines       10839    10848       +9     
  Branches     3064     3066       +2     
==========================================
+ Hits        10070    10081      +11     
+ Misses        343      342       -1     
+ Partials      426      425       -1     
Flag Coverage Δ
unittest 92.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/space-infix-ops.ts 97.43% <100.00%> (+7.43%) ⬆️

@FDIM FDIM changed the title fix(eslint-plugin): [space-infix-ops] support for class properties fix(eslint-plugin): [space-infix-ops] support for class properties and type aliases Mar 28, 2021
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Mar 28, 2021
@bradzacher bradzacher changed the title fix(eslint-plugin): [space-infix-ops] support for class properties and type aliases feat(eslint-plugin): [space-infix-ops] support for class properties and type aliases Mar 28, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution!

@bradzacher bradzacher merged commit 5414bf2 into typescript-eslint:master Mar 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[space-infix-ops] Ignored around field initializers
2 participants