Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from huksy to simple-git-hooks #3222

Closed
JounQin opened this issue Mar 24, 2021 · 6 comments
Closed

migrate from huksy to simple-git-hooks #3222

JounQin opened this issue Mar 24, 2021 · 6 comments
Labels
awaiting response Issues waiting for a reply from the OP or another party repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JounQin
Copy link
Contributor

JounQin commented Mar 24, 2021

  1. We can start having all husky 5 benefits (performance, small size) without waiting for MIT license for husky 5.
  2. simple-git-hooks is smaller than husky 5.
  3. husky 5 requires extra scripts in package.json.
  4. husky 5 requires an extra pinst dependency for Yarn 2. simple-git-hooks has out-of-the box Yarn 2 support.

lint-staged/lint-staged#954 (comment)
@JounQin JounQin added package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look labels Mar 24, 2021
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party repo maintenance things to do with maintenance of the repo, and not with code/docs and removed package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look labels Mar 29, 2021
@bradzacher
Copy link
Member

what are the actual benefits of the change? TBH I don't care about size (it's installed once per checkout) or yarn 2 support (most people haven't switched to yarn 2 due to the overhead)

@JounQin
Copy link
Contributor Author

JounQin commented Mar 30, 2021

Easier to maintain and understand, no more extra .husky files.

@schmod
Copy link

schmod commented Apr 13, 2021

Husky is once again MIT licensed

@JounQin
Copy link
Contributor Author

JounQin commented Apr 14, 2021

License is not the key point.

There are a lot of objections on husky's upgrade like typicode/husky#921.

And it is much more 'complex' than before like typicode/husky#929.

@remcohaszing
Copy link
Contributor

typicode/husky#929 issue literally starts with:

I love how the latest husky incorporates core.hooksPath. This makes it so much simpler.

@bradzacher
Copy link
Member

For now - I'm okay with us using husky. I don't think there's any strong arguments for us to migrate across given that we're already on the latest version of husky.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@remcohaszing @schmod @bradzacher @JounQin