Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [object-curly-spacing] support MappedType #3176

Conversation

MatthiasKunnen
Copy link
Contributor

@MatthiasKunnen MatthiasKunnen commented Mar 12, 2021

The rule did support not MappedType (var d: {[k in 'union']: any}).

This PR adds tests and support.

This fixes #3175.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MatthiasKunnen!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #3176 (2fb235f) into master (e3a3ea0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3176   +/-   ##
=======================================
  Coverage   92.91%   92.92%           
=======================================
  Files         316      316           
  Lines       10818    10824    +6     
  Branches     3059     3059           
=======================================
+ Hits        10052    10058    +6     
  Misses        342      342           
  Partials      424      424           
Flag Coverage Δ
unittest 92.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/object-curly-spacing.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Mar 12, 2021
@MatthiasKunnen MatthiasKunnen force-pushed the issue-3175-object-curly-spacing-mapped-type branch from a89f767 to 2fb235f Compare March 21, 2021 15:06
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution!

@bradzacher bradzacher merged commit 0557a43 into typescript-eslint:master Mar 21, 2021
@MatthiasKunnen MatthiasKunnen deleted the issue-3175-object-curly-spacing-mapped-type branch March 22, 2021 11:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[object-curly-spacing] Rule does not apply to MappedType
2 participants