fix(eslint-plugin): [promise-function-async] bad fixer with computed and literal methods #3163
Conversation
|
Thanks for the PR, @phaux! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
=======================================
Coverage 92.91% 92.92%
=======================================
Files 316 316
Lines 10808 10820 +12
Branches 3056 3059 +3
=======================================
+ Hits 10042 10054 +12
Misses 342 342
Partials 424 424
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bradzacher
changed the title
| TSESTree, | ||
| } from '@typescript-eslint/experimental-utils'; | ||
| import { last } from 'lodash'; |
There was a problem hiding this comment.
we'd rather avoid adding a dependency on lodash for such trivial things.
Please inline the function impl!
| // this function is a class method or object function property shorthand | ||
| const method = node.parent; | ||
|
|
||
| /** the token to put `async` before */ |
There was a problem hiding this comment.
nitpick
| /** the token to put `async` before */ | |
| /// the token to put `async` before |
bradzacher
added
the
awaiting response
bradzacher
removed
the
awaiting response
public"foo"() {}now adds a space so it doesn't becomepublicasync "foo"() {}["computed"]() {}now inserts async in the correct position instead of[async "computed"]() {}