Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-var-requires] report when used in type assertion #3074

Merged
merged 2 commits into from Feb 19, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 19, 2021

This fixes issue with no-var-requires not reporting issues for <Foo>require('./foo.json');

i found this issue while doing https://github.com/typescript-eslint/typescript-eslint/pull/3005/files#r571368246

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Feb 19, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 merged commit 763a252 into master Feb 19, 2021
@armano2 armano2 deleted the fix/no-var-requires-type-assertion branch February 19, 2021 10:56
This was referenced Mar 6, 2021
This was referenced Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants