Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): correct test names on windows for semantic-diagnostics-enabled #3060

Merged
merged 4 commits into from Feb 18, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 15, 2021

This issue with tests is present only on windows and was introduced in #3045
https://github.com/typescript-eslint/typescript-eslint/pull/3045/files#r575688728

integration tests are failing due to #3045

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 added the tests anything to do with testing label Feb 15, 2021
@armano2 armano2 changed the title fix: correct test names on windows for semantic-diagnostics-enabled test: correct test names on windows for semantic-diagnostics-enabled Feb 15, 2021
@armano2 armano2 changed the title test: correct test names on windows for semantic-diagnostics-enabled fix(typescript-estree): correct test names on windows for semantic-diagnostics-enabled Feb 15, 2021
@armano2 armano2 enabled auto-merge (squash) February 15, 2021 20:36
@armano2
Copy link
Member Author

armano2 commented Feb 18, 2021

@bradzacher do you have an idea why codecov/patch and codecov/project is keep failing?

@bradzacher
Copy link
Member

nope - it's a pretty shitty service TBH - it seemingly only works like 30% of the time.

@armano2
Copy link
Member Author

armano2 commented Feb 18, 2021

hmm, it seem that this error is already reported and there seem to be workaround for this.

https://community.codecov.io/t/codecov-status-stuck-at-waiting-for-status-to-be-reported-on-github/341/32

https://docs.codecov.io/docs/codecovyml-reference#codecovrequire_ci_to_pass

i will submit, pr and try disabling this option

This was referenced Mar 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants