Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-module-boundary-types] check allowNames on function declarations and property methods #3051

Merged
merged 2 commits into from Feb 13, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #3033

… on function declarations and property methods
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #3051 (15aaed5) into master (5e5d9b9) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
+ Coverage   92.64%   92.65%   +0.01%     
==========================================
  Files         314      314              
  Lines       10674    10675       +1     
  Branches     3026     3027       +1     
==========================================
+ Hits         9889     9891       +2     
+ Misses        363      362       -1     
  Partials      422      422              
Flag Coverage Δ
unittest 92.65% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 89.47% <75.00%> (+0.73%) ⬆️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher added the bug Something isn't working label Feb 13, 2021
@bradzacher bradzacher merged commit 0ade469 into typescript-eslint:master Feb 13, 2021
This was referenced Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explicit-module-boundary-types] allowNames doesn't work on function and method expressions
2 participants