New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-estree): throw custom error instead of plain object #3011
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3011 +/- ##
=======================================
Coverage 92.87% 92.88%
=======================================
Files 314 314
Lines 10670 10677 +7
Branches 3026 3026
=======================================
+ Hits 9910 9917 +7
Misses 344 344
Partials 416 416
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to add either a snapshot serialiser so that we can show the line/column in the snapshot output?
This will help us verify things don't regress.
simple serializer for this error is added, i'm unsure about format tho |
4a0c760
to
b183890
Compare
d4b5844
to
2bae582
Compare
additionally expose fileName of file that error got reported
897bedb
to
582ff63
Compare
throw custom error instead of plain object
additionally expose
fileName
of file that error got reportedI'm unsure if
ParseError
TSError
name is correct.see: https://github.com/Microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work
note: depends how we look at this change, this can be considered a breaking change, even if names of exposed public fields did not change
fixes #2400