Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): fix visiting of TSImportType #3008

Merged
merged 1 commit into from Feb 6, 2021

Conversation

bradzacher
Copy link
Member

Fixes #3006

@bradzacher bradzacher added the bug Something isn't working label Feb 6, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #3008 (f0f175b) into master (3cb3aad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3008   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         314      314           
  Lines       10663    10664    +1     
  Branches     3023     3023           
=======================================
+ Hits         9887     9888    +1     
  Misses        355      355           
  Partials      421      421           
Flag Coverage Δ
unittest 92.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 89.36% <100.00%> (+0.11%) ⬆️

@bradzacher bradzacher merged commit ce4fcbf into master Feb 6, 2021
@bradzacher bradzacher deleted the 3006-import-type branch February 6, 2021 19:50
@armano2 armano2 added scope analyser Issues that are caused by bugs/incomplete cases in the scope analyser package: scope-manager Issues related to @typescript-eslint/scope-manager and removed scope analyser Issues that are caused by bugs/incomplete cases in the scope analyser labels Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: scope-manager Issues related to @typescript-eslint/scope-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'default' is not defined in typeof import
2 participants