feat(typescript-estree): correct logic used to escape string literals #2995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add correct unescaping of xhml string literals and jsxText that is now applied only in jsx context.
logic for this PR has been crafted base on current implementaion of
acorn-jsx
andbabel
https://github.com/acornjs/acorn-jsx/blob/master/index.js
https://github.com/babel/babel/blob/main/packages/babel-parser/src/plugins/jsx/index.js
notable changes:
&
,<
,>
,"
,'
we will now handle all valid values, additionally support for unescaping hex and decimal codepoints has been added.see: https://github.com/lodash/lodash/blob/2f79053d7bc7c9c9561a30dda202b3dcd2b72b90/unescape.js#L2
#2279