fix(eslint-plugin): [no-extra-parens] handle ESLint 7.19.0

[midgleyc]

Fixes #2986.

This works on eslint 7.19.0, but breaks on earlier versions (I'd expect). If I left in the previous version of the function (and types) with 'ForInStatement, ForOfStatement', it might work on those as well.

If I don't do that, I think the version of eslint in package.json should be bumped.

Which would you prefer?

[typescript-eslint]

Thanks for the PR, @midgleyc!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[bradzacher]

Thanks for the PR!

We need to maintain compatibility with old versions of eslint as well as new versions - so we need to maintain a (guarded) call to the old selector.

[codecov]

Codecov Report

Merging #2993 (982bb74) into master (58476a9) will decrease coverage by 0.07%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
- Coverage   92.71%   92.63%   -0.08%     
==========================================
  Files         313      313              
  Lines       10655    10665      +10     
  Branches     3018     3021       +3     
==========================================
+ Hits         9879     9880       +1     
- Misses        355      363       +8     
- Partials      421      422       +1     

Flag	Coverage Δ
unittest	92.63% <30.76%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	84.72% <30.76%> (-12.06%)	⬇️

[bradzacher]

Instead of using a semver check here, as these can be pretty hairy to get right.

Just guard appropriately.

if (rules.ForInStatement && rules.ForOfStatement) {
  // new version
} else {
  // old version
}

[midgleyc]

Nice, thanks!

[bradzacher]

thanks for doing this!

[orgads]

When do you plan to release?