Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [consistent-type-imports] incorrect handling of computed property type signatures #2990

Merged
merged 1 commit into from Feb 1, 2021

Conversation

bradzacher
Copy link
Member

Fixes #2989

@bradzacher bradzacher added the bug Something isn't working label Feb 1, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2990 (dca2f8e) into master (7b701a3) will decrease coverage by 0.02%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
- Coverage   92.74%   92.71%   -0.03%     
==========================================
  Files         313      313              
  Lines       10639    10655      +16     
  Branches     3018     3018              
==========================================
+ Hits         9867     9879      +12     
- Misses        353      355       +2     
- Partials      419      421       +2     
Flag Coverage Δ
unittest 92.71% <85.18%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts 93.64% <85.18%> (-1.36%) ⬇️

@bradzacher bradzacher merged commit 58f2655 into master Feb 1, 2021
@bradzacher bradzacher deleted the 2989-CTI-computed-property-sig branch February 1, 2021 08:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[consistent-type-imports] Regression 4.14.0/1 error when import used as key in type object
1 participant