Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [prom-func-async] report only function head #2872

Merged
merged 11 commits into from Feb 28, 2021
Merged

feat(eslint-plugin): [prom-func-async] report only function head #2872

merged 11 commits into from Feb 28, 2021

Conversation

phaux
Copy link
Contributor

@phaux phaux commented Dec 12, 2020

Depends on #2845.

Changes report location to be only the function head without the whole body, like in explicit-module-boundary-types.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @phaux!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #2872 (b14ae27) into master (5e2a993) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2872   +/-   ##
=======================================
  Coverage   92.87%   92.88%           
=======================================
  Files         314      315    +1     
  Lines       10670    10677    +7     
  Branches     3026     3028    +2     
=======================================
+ Hits         9910     9917    +7     
  Misses        344      344           
  Partials      416      416           
Flag Coverage Δ
unittest 92.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/promise-function-async.ts 97.43% <100.00%> (+0.06%) ⬆️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100.00% <100.00%> (ø)
...kages/eslint-plugin/src/util/getFunctionHeadLoc.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the enhancement New feature or request label Dec 12, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be rebased on master.

changes itself LGTM!

* ^^^^^^^^^
* ```
*/
export function getFunctionHeadLoc(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're here - one case I believe this code doesn't correctly handle is decorators because decorators are included within the method's start.

Eg this code will highlight:

class Foo {
  @deco
  ^^^^^
  foo() {}
  ^^^^^
}

this has confused some people in the past (eg #751)

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Dec 21, 2020
@phaux
Copy link
Contributor Author

phaux commented Feb 10, 2021

Sorry for not responding for so long. I had a break from open source. I will get to it on this weekend or maybe the next.

@bradzacher
Copy link
Member

There's no rush! Whenever you're comfortable and ready.

@phaux
Copy link
Contributor Author

phaux commented Feb 28, 2021

Done!

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Feb 28, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

This was referenced Mar 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants