Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): support type annotations on catch clauses #2306

Merged
merged 1 commit into from Jul 19, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jul 19, 2020

reference #2260

Split these changes out of #2202 to better focus the PR

@bradzacher bradzacher added the enhancement New feature or request label Jul 19, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #2306 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2306   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files         283      283           
  Lines        9058     9061    +3     
  Branches     2482     2483    +1     
=======================================
+ Hits         8434     8437    +3     
  Misses        301      301           
  Partials      323      323           
Flag Coverage Δ
#unittest 93.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...escript-estree/src/semantic-or-syntactic-errors.ts 87.50% <ø> (ø)
packages/typescript-estree/src/convert.ts 98.62% <100.00%> (+<0.01%) ⬆️

@bradzacher bradzacher merged commit b5afe9c into master Jul 19, 2020
@bradzacher bradzacher deleted the ts4-syntax-pt1 branch July 19, 2020 01:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant