Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [unbound-method] false positive on property function initializer #1890

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Conversation

greyscaled
Copy link
Contributor

resolves #1869

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vapurrmaid!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #1890 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
- Coverage   94.39%   94.38%   -0.02%     
==========================================
  Files         164      164              
  Lines        7583     7585       +2     
  Branches     2179     2180       +1     
==========================================
+ Hits         7158     7159       +1     
- Misses        182      183       +1     
  Partials      243      243              
Flag Coverage Δ
#unittest 94.38% <100.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 95.23% <100.00%> (-1.49%) ⬇️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic itself looks good.
one minor change

thanks for this!

packages/eslint-plugin/src/rules/unbound-method.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party bug Something isn't working labels Apr 13, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for this

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 13, 2020
@bradzacher bradzacher changed the title fix(eslint-plugin): [unbound-method] property function initializer fix(eslint-plugin): [unbound-method] false positive on property function initializer Apr 13, 2020
@bradzacher bradzacher merged commit f1c3b18 into typescript-eslint:master Apr 13, 2020
@greyscaled greyscaled deleted the unbound-fn-prop branch April 13, 2020 16:57
@markfields
Copy link

Thanks @vapurrmaid!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unbound-method] referencing a property with a function type should cause error
4 participants