feat(eslint-plugin-internal): add prefer-ast-types-enum

[G-Rath]

closes #1503

I assume it has to be published before it can be used?

[typescript-eslint]

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #1508 into master will decrease coverage by 0.03%.
The diff coverage is 85%.

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage    95.6%   95.57%   -0.04%     
==========================================
  Files         148      149       +1     
  Lines        6664     6684      +20     
  Branches     1909     1915       +6     
==========================================
+ Hits         6371     6388      +17     
- Misses        111      112       +1     
- Partials      182      184       +2

Impacted Files	Coverage Δ
packages/eslint-plugin-internal/src/rules/index.ts	0% <0%> (ø)	⬆️
...plugin-internal/src/rules/prefer-ast-types-enum.ts	89.47% <89.47%> (ø)

[armano2]

I assume it has to be published before it can be used?

it should work without publishing (in development we are using local packages for linting)

you forgot to add it to packages/eslint-plugin-internal/src/rules/index.ts

[bradzacher]

lgtm

one nit on the implementation, just for this repo.
armano is right; add it to the index and do a build, then you'll be able to config it and run it.

you're a legend, thanks for doing this!

[G-Rath]

@bradzacher

We've gotten most of the cases, but it'd be good to guard against this explicitly in the codebase.

✖ 298 problems (298 errors, 0 warnings)
298 errors and 0 warnings potentially fixable with the --fix option.

😂

But on a serious note, I'm going to open a new PR based off this one for the fixes - the primary interesting one is constructor: since that exists, these are being flagged:

typescript-eslint/packages/eslint-plugin/tests/rules/member-ordering.test.ts

Line 71 in 718cd88

options: [{ default: ['signature', 'field', 'constructor', 'method'] }],

I personally don't have a major problem with it, but you might feel differently :)

[G-Rath]

Also, I've renamed the rule to prefer-ast-types-enum, as that's more sensible.

[bradzacher]

thanks for this!