Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): crash in no-unnecessary-type-arguments #1401

Merged
merged 2 commits into from
Jan 2, 2020
Merged

fix(eslint-plugin): crash in no-unnecessary-type-arguments #1401

merged 2 commits into from
Jan 2, 2020

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 2, 2020

This PR contains fix for regression introduced in #1381

fixes #1400

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Jan 2, 2020
@armano2 armano2 self-assigned this Jan 2, 2020
@typescript-eslint

This comment has been minimized.

Sign in to view
bradzacher
bradzacher approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@bradzacher bradzacher merged commit 01c939f into typescript-eslint:master Jan 2, 2020
@armano2 armano2 deleted the fix/1400-no-unnecessary-type-arguments branch January 2, 2020 19:53
This was referenced Jan 15, 2020
Open
Open
Open
Open
This was referenced Feb 8, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-type-arguments] crashes with "TypeError: inputs is not iterable"
2 participants
@armano2 @bradzacher