Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings due to unmet peer dependency typescript #1287

Closed
vieira opened this issue Nov 30, 2019 · 1 comment
Closed

Warnings due to unmet peer dependency typescript #1287

vieira opened this issue Nov 30, 2019 · 1 comment
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@vieira
Copy link

vieira commented Nov 30, 2019

Hello,

I use eslint-plugin-jest which has a dependency to @typescript-eslint/experimental-utils. Since #1120 yarn started emitting warnings:

warning "eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta"

As I understand from jest-community/eslint-plugin-jest#467 other projects expect to use @typescript-eslint/typescript-estree without requiring TS by consumers.

In my case, I use jest and eslint-plugin-jest in a project without typescript.

@vieira vieira added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for maintainers to take a look labels Nov 30, 2019
@bradzacher bradzacher removed the triage Waiting for maintainers to take a look label Nov 30, 2019
@bradzacher
Copy link
Member

You can ignore this warning.
There's nothing we can really do about this right now.

Could potentially convince tsutils to add optional peer dep meta config, but I don't know if they'd want to do that.
It would take a breaking change to restructure the dependency tree of the packages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

No branches or pull requests

2 participants