Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): optional chain support in rules (part 1) #1253

Merged
merged 15 commits into from
Nov 25, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Nov 23, 2019

See #1051

  • consistent-type-assertions
  • explicit-function-return-type
  • func-call-spacing
  • no-array-constructor
  • no-floating-promises
  • no-inferrable-types
  • no-misused-promises
  • no-require-imports
  • no-var-requires
  • prefer-for-of
  • prefer-includes

@bradzacher bradzacher added the enhancement New feature or request label Nov 23, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1253 into master will decrease coverage by <.01%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
- Coverage   94.22%   94.22%   -0.01%     
==========================================
  Files         129      129              
  Lines        5611     5627      +16     
  Branches     1575     1581       +6     
==========================================
+ Hits         5287     5302      +15     
  Misses        180      180              
- Partials      144      145       +1
Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-require-imports.ts 100% <ø> (ø) ⬆️
...ges/eslint-plugin/src/rules/no-misused-promises.ts 100% <ø> (ø) ⬆️
...es/eslint-plugin/src/rules/no-array-constructor.ts 100% <ø> (ø) ⬆️
...int-plugin/src/rules/consistent-type-assertions.ts 87.09% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/prefer-for-of.ts 88.57% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/prefer-includes.ts 100% <100%> (ø) ⬆️
...-plugin/src/rules/explicit-function-return-type.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 100% <100%> (ø) ⬆️
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.1% <100%> (ø) ⬆️
...ackages/eslint-plugin/src/rules/no-var-requires.ts 100% <100%> (ø) ⬆️
... and 1 more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant