Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): reduce bundle footprint of tsutils #1177

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Nov 6, 2019

If you don't need everything offered by this package, you can select what should be imported.

-- from https://www.npmjs.com/package/tsutils

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @thorn0!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about how big it would be for your web versions.

Thanks for this - LGTM

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1177 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         120      120           
  Lines        5195     5195           
  Branches     1440     1440           
=======================================
  Hits         4883     4883           
  Misses        178      178           
  Partials      134      134
Impacted Files Coverage Δ
packages/typescript-estree/src/convert-comments.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher merged commit c8fe515 into typescript-eslint:master Nov 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants