Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): don't use typescript's synthetic default #1156

Merged
merged 1 commit into from Oct 29, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1153

@bradzacher bradzacher added the bug Something isn't working label Oct 29, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1156 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files         120      120           
  Lines        5220     5220           
  Branches     1445     1445           
=======================================
  Hits         4909     4909           
  Misses        177      177           
  Partials      134      134
Impacted Files Coverage Δ
...estree/src/create-program/createIsolatedProgram.ts 73.91% <100%> (ø) ⬆️
...-estree/src/create-program/createDefaultProgram.ts 76.19% <100%> (ø) ⬆️
...pt-estree/src/create-program/createWatchProgram.ts 93.29% <100%> (ø) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 75% <100%> (ø) ⬆️
...ript-estree/src/create-program/createSourceFile.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher changed the title fix(typescript-estree): don't use typescript's synthetic default import fix(typescript-estree): don't use typescript's synthetic default Oct 29, 2019
@bradzacher bradzacher merged commit 17c956e into master Oct 29, 2019
@bradzacher bradzacher deleted the ts-default-import branch October 29, 2019 16:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default import requires typescript-estree dependents to have esModuleInterop: true in tsconfg
2 participants