Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): normalize paths to fix cache miss on windows #1128

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1126

Windows paths can come in with forward or back slashes.
Need to normalize the paths so they have the same slashes.

NGL switching from mac to windows to do this was so painful.

@bradzacher bradzacher added the bug Something isn't working label Oct 23, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how this could be tested...

@bradzacher
Copy link
Member Author

We've got great coverage of Mac (because that's what I dev on), and linux (because that's what the CI currently runs on), but no coverage on windows.

That didn't matter in the past, because we never did anything around filenames.
With the addition of this "watching" code, we need to add windows integration tests to the CI.

@JamesHenry said that it's easy to setup on our CI, but I don't know how to configure it 😅

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1128 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   94.07%   94.07%   +<.01%     
==========================================
  Files         120      120              
  Lines        5213     5214       +1     
  Branches     1443     1443              
==========================================
+ Hits         4904     4905       +1     
  Misses        177      177              
  Partials      132      132
Impacted Files Coverage Δ
...ges/typescript-estree/src/create-program/shared.ts 80% <33.33%> (+1.42%) ⬆️

@bradzacher bradzacher merged commit 6d0f2ce into master Oct 23, 2019
@bradzacher bradzacher deleted the windows-path-bug branch October 23, 2019 04:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.5.0][Windows] 100% cache miss rate for CLI runs
2 participants