Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix filename handling for vue JSX + markdown #1127

Merged
merged 12 commits into from Nov 3, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Oct 22, 2019

Integrations I never knew existed:

  • JSX in vue files
  • Parsing of markdown snippets via eslint-plugin-markdown

Fixes #1123
Fixes #1124

@bradzacher bradzacher added the bug Something isn't working label Oct 22, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JounQin
Copy link
Contributor

JounQin commented Oct 22, 2019

Can we add a test case for .mdx with eslint-plugin-mdx which is definitely different from eslint-plugin-markdown?

More detail: https://github.com/rx-ts/eslint-mdx

@bradzacher
Copy link
Member Author

feel free to raise a PR with an integration test case for your tool if you want.
I don't know what MDX is, or how it works, so it would be better if you, as a maintainer of that project, adds an integration test.

The Vue stuff that we've added has been cobbled together by copy+pasting from issues that have been raised, and then those who know vue have PR'd modifications to the config appropriately.

@JounQin
Copy link
Contributor

JounQin commented Oct 22, 2019

Thx for your explanation, I will raise another PR after your PR merged ASAP.

@bradzacher bradzacher marked this pull request as ready for review October 23, 2019 04:48
@bradzacher bradzacher merged commit 366518f into master Nov 3, 2019
@bradzacher bradzacher deleted the more-integrations branch November 3, 2019 22:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX cannot be resolved in Vue and Ts [2.5.0] Markdown parsing failed
2 participants