Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): better handle canonical paths #1111

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Oct 20, 2019

Whilst investigating #1110, I found that there are some cases where typescript will give us their "canonical path" instead of the actual path.

This is a problem on unix because the canonical path is all lower case, which means we can fail to fire directory updates, because the watcher path doesn't match.

This PR adds a pseudo-nominal type (waiting for the day typescript adds it for real) which ensures (at typecheck time) that the canonical path passed in where required.

@bradzacher bradzacher added the bug Something isn't working label Oct 20, 2019
@typescript-eslint

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #1111 into master will decrease coverage by 0.02%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   94.09%   94.07%   -0.03%     
==========================================
  Files         120      120              
  Lines        5200     5211      +11     
  Branches     1442     1442              
==========================================
+ Hits         4893     4902       +9     
- Misses        176      177       +1     
- Partials      131      132       +1
Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 93.12% <100%> (+0.13%) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 78.57% <72.72%> (-4.77%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants