Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): correct semver check range #1109

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Conversation

bradzacher
Copy link
Member

It wasn't matching 3.6.4 as valid because I missed the pipe.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #1109 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1109   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files         120      120           
  Lines        5200     5200           
  Branches     1442     1442           
=======================================
  Hits         4893     4893           
  Misses        176      176           
  Partials      131      131
Impacted Files Coverage Δ
packages/typescript-estree/src/parser.ts 95.57% <100%> (ø) ⬆️

@bradzacher bradzacher merged commit 2fc9bd2 into master Oct 19, 2019
@bradzacher bradzacher deleted the bz-patch-1 branch October 19, 2019 22:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants