Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): handle running out of fs watchers #1088

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1080

I followed typescript's lead here, and fall back to polling if chokidar throws an error when attempting to use fs watchers.

I also added support for reusing watchers, to attempt to conserve resources, and reduce the total number of watchers that we setup.

I also decided it was time to setup some logging to help with debugging.
The logging can be shown via DEBUG=typescript-eslint:* yarn lint

@bradzacher bradzacher added the bug Something isn't working label Oct 15, 2019
@typescript-eslint

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1088 into master will decrease coverage by 0.05%.
The diff coverage is 76.92%.

@@            Coverage Diff            @@
##           master   #1088      +/-   ##
=========================================
- Coverage   94.06%     94%   -0.06%     
=========================================
  Files         115     115              
  Lines        5086    5107      +21     
  Branches     1423    1426       +3     
=========================================
+ Hits         4784    4801      +17     
- Misses        174     177       +3     
- Partials      128     129       +1
Impacted Files Coverage Δ
packages/typescript-estree/src/parser.ts 92.2% <100%> (+0.31%) ⬆️
packages/typescript-estree/src/tsconfig-parser.ts 85.24% <68.96%> (-1.67%) ⬇️

@JamesHenry JamesHenry merged commit ec62747 into master Oct 16, 2019
@JamesHenry JamesHenry deleted the handle-out-of-watchers branch October 16, 2019 01:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.4.0][Watch][Linux] Out of file watchers errors
2 participants