Changes to configurations for 6.0.0 #6014
Replies: 11 comments 16 replies
-
|
I think this is a good style to enforce and most of the time having a duplicate is a bug.
Some codebases do use redundant constituents as a way of documenting possible values.
This rule was explicitly added to the recommended set in v3.0.0 - #1423 👍 LGTM - no comment➕🛑
|
Beta Was this translation helpful? Give feedback.
-
|
👍 from me on most of that! Just one thread:
Is there a strong argument to have this and |
Beta Was this translation helpful? Give feedback.
-
|
declare const num: number;
declare const str: string;
declare const bool: boolean;
declare const obj: {};
declare const objToStr: { toString(): string };
declare const any: any;
declare const unk: unknown;
num + num; // NO error
num + str; // RPO error
// num + bool; // TS error
// num + obj; // TS error
// num + objToStr; // TS error
num + any; // RPO error
// num + unk; // TS error
str + str; // NO error
str + bool; // RPO error
str + obj; // NBTS + RPO error ////////// ONLY CASE NBTS ERRORS ON
str + objToStr; // RPO error
str + any; // RPO error
// str + unk; // TS error
// bool + bool; // TS error
// bool + obj; // TS error
// bool + objToStr; // TS error
bool + any; // RPO error
// bool + unk; // TS error
// obj + obj; // TS error
// obj + objToStr; // TS error
obj + any; // RPO error
// obj + unk; // TS error
// objToStr + objToStr; // TS error
objToStr + any; // RPO error
// objToStr + unk; // TS error
any + any; // RPO error
any + unk; // RPO error
// unk + unk; // TS error |
Beta Was this translation helpful? Give feedback.
-
|
Got it, thanks - that makes a lot of sense to me. Keeping in 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Filed #6110 to add some friendly options to it. I'll propose we enable those options for both rules by default. |
Beta Was this translation helpful? Give feedback.
-
|
Hello, I was directed here from eslint/eslint#16557 (reply in thread) about feedback on the defaults. Looking at the configuration we have in our app, there are two rules that I would change from the table above:
Other than these, I'm on board with the changes to remove rules that have been deemed too opinionated or obsoleted by a code formatter. Thank-you for all the work you are doing on TS-ESLint integration. |
Beta Was this translation helpful? Give feedback.
-
🤔 do you have any examples of this? Out of those two cases:
Yeah this is unfortunate. I would really love to be able to enable something in the recommended ruleset that discourages type assertions - since they're almost always indicative of a flaw in the type system. But sometimes that flaw is in TypeScript itself, and/or something not really able to be overcome. Hence lumping it into |
Beta Was this translation helpful? Give feedback.
-
|
Are there any specific criteria for |
Beta Was this translation helpful? Give feedback.
-
|
Good question. We should document this somewhere! The description on https://typescript-eslint.io/linting/configs#recommended-configurations is a little vague:
The heuristics I've been using have been roughly:
How does that feel? |
Beta Was this translation helpful? Give feedback.
-
|
I am not an expert, but I think it is generally good. |
Beta Was this translation helpful? Give feedback.
-
|
I've been thinking about the indicators of a
|
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
hey @reintroducing - could you please file an issue for each of your questions? |
Beta Was this translation helpful? Give feedback.
-
Absolutely, apologies for the noise. |
Beta Was this translation helpful? Give feedback.
-
|
@bradzacher sorry, i mean this to be a reply to your comment above but did it through my phone and realized just now it went as a new comment (thus creating even more noise). Feel free to mark this one off topic as well (or just completely delete it). |
Beta Was this translation helpful? Give feedback.
-
|
Where is |
Beta Was this translation helpful? Give feedback.
-
|
Ah good callout, thank you! It was merged after the last time I went over this list. Just updated now to indicate it's meant to move from strict to recommended-type-checked. |
Beta Was this translation helpful? Give feedback.
-
|
I'm testing the delta but it doesn't seem to be applying the new rules in some cases. For example, when I comment out my existing |
Beta Was this translation helpful? Give feedback.
-
|
Is it possible that the other plugins are forcing it back to v5 because they need it as a dependency? |
Beta Was this translation helpful? Give feedback.
-
|
That is a possibility, yes. You can try debugging techniques such as |
Beta Was this translation helpful? Give feedback.
-
|
Would this be a good opportunity to change the default of |
Beta Was this translation helpful? Give feedback.
-
|
Oof, sorry for the delay @tylerlaprade - I'd missed this comment. I believe we're keeping it |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the reply, @JoshuaKGoldberg! I don't see those two options as equivalent nor as opinionated, though. As per the current documentation, while The default for all other nullable primitives is Apologies if I missed it, but what makes |
Beta Was this translation helpful? Give feedback.
-
|
D'oh! You're right, I mistook the two. Per #6760 we're going to want to make a few changes (or at least: I'll propose them). Linking here so it's not missed. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Noting a change from #7110: we're going to keep |
Beta Was this translation helpful? Give feedback.
-
|
#7110 was merged into the |
Beta Was this translation helpful? Give feedback.
-
|
Just discovered that the default where completely changed for |
Beta Was this translation helpful? Give feedback.
-
Edit: see #7130 for small touchups to these changes
Overview
Similar to what @bradzacher did for 5.0.0 (in #3746), I'm going to put forward the new recommended set ahead of time. We're looking for feedback from the community before we go ahead and make the changes.
These new configuration values are what we are planning on releasing with the v6 major version as part of its breaking changes. You can read more about v6 in the Announcing typescript-eslint v6 beta blog post. The original plan for changing the configs was discussed in #6019.
🙏 Please - give v6 a try, and give us feedback on the these new configuration values! Here or in the typescript-eslint Discord's
v6channel. We'll cross-post any important discussions here for visibility.Table Key
Recommendations Table
adjacent-overload-signaturesarray-typeawait-thenableban-ts-commentban-tslint-commentban-typesbrace-styleclass-literal-property-stylecomma-danglecomma-spacingconsistent-generic-constructorsconsistent-indexed-object-styleconsistent-type-assertionsconsistent-type-definitionsconsistent-type-exportsconsistent-type-importsdefault-param-lastdot-notationexplicit-function-return-typeexplicit-member-accessibilityexplicit-module-boundary-typesfunc-call-spacingindentinit-declarationskeyword-spacinglines-between-class-memberslines-around-commentmember-delimiter-stylemember-orderingmethod-signature-stylenaming-conventionno-array-constructorno-base-to-stringno-confusing-non-null-assertionno-confusing-void-expressionno-dupe-class-membersno-duplicate-enum-valuesno-duplicate-importsno-duplicate-type-constituentsno-dynamic-deleteno-empty-functionno-empty-interfaceno-explicit-anyno-extra-non-null-assertionno-extra-parensno-extra-semino-extraneous-classno-floating-promisesno-for-in-arrayno-implicit-any-catchno-implied-evalno-inferrable-typesno-invalid-thisno-invalid-void-typeallowAsThisParametertotrueno-loop-funcno-loss-of-precisionno-magic-numbersno-meaningless-void-operatorno-misused-newno-misused-promisesno-mixed-enumsno-namespaceno-non-null-asserted-nullish-coalescingno-non-null-asserted-optional-chainno-non-null-assertionno-parameter-propertiesno-redeclareno-redundant-type-constituentsno-require-importsno-restricted-importsno-shadowno-this-aliasno-throw-literalno-type-aliasno-unnecessary-boolean-literal-compareno-unnecessary-conditionno-unnecessary-qualifierno-unnecessary-type-argumentsno-unnecessary-type-assertionno-unnecessary-type-constraintno-unsafe-argumentno-unsafe-assignmentno-unsafe-callno-unsafe-declaration-mergingno-unsafe-enum-comparisonno-unsafe-member-accessno-unsafe-returnno-unused-expressionsno-unused-varsno-use-before-defineno-useless-constructorno-useless-empty-exportno-var-requiresnon-nullable-type-assertion-styleobject-curly-spacingpadding-line-between-statementsparameter-propertiesprefer-as-constprefer-enum-initializersprefer-for-ofprefer-function-typeprefer-includesprefer-literal-enum-memberprefer-namespace-keywordprefer-nullish-coalescingfalseprefer-optional-chainprefer-readonlyprefer-readonly-parameter-typesprefer-reduce-type-parameterprefer-regexp-execprefer-return-this-typeprefer-string-starts-ends-withprefer-ts-expect-errorpromise-function-asyncquotesrequire-array-sort-compareignoreStringArraysrequire-awaitrestrict-plus-operandscheckCompoundAssignmentsrestrict-template-expressionsallowAnyreturn-awaitsemisort-type-constituentssort-type-union-intersection-membersspace-before-blocksspace-before-function-parenspace-infix-opsstrict-boolean-expressionsswitch-exhaustiveness-checktriple-slash-referencetype-annotation-spacingtypedefunbound-methodunified-signaturesBeta Was this translation helpful? Give feedback.
All reactions