From e220691b7f001b7f1af96a19d1c67f67b2aba7b2 Mon Sep 17 00:00:00 2001 From: Brad Zacher Date: Thu, 27 Oct 2022 16:27:06 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Josh Goldberg --- packages/utils/src/eslint-utils/rule-tester/RuleTester.ts | 4 ++-- .../utils/tests/eslint-utils/rule-tester/RuleTester.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/utils/src/eslint-utils/rule-tester/RuleTester.ts b/packages/utils/src/eslint-utils/rule-tester/RuleTester.ts index b925021572c..90c2f194386 100644 --- a/packages/utils/src/eslint-utils/rule-tester/RuleTester.ts +++ b/packages/utils/src/eslint-utils/rule-tester/RuleTester.ts @@ -146,7 +146,7 @@ class RuleTester extends BaseRuleTester.RuleTester { }; (this.staticThis.describe as DescribeWithSkip).skip(name, () => { this.staticThis.it( - 'All test skipped due to unsatisfied constructor dependency constraints', + 'All tests skipped due to unsatisfied constructor dependency constraints', () => {}, ); }); @@ -154,7 +154,7 @@ class RuleTester extends BaseRuleTester.RuleTester { // otherwise just declare an empty test this.staticThis.describe(name, () => { this.staticThis.it( - 'All test skipped due to unsatisfied constructor dependency constraints', + 'All tests skipped due to unsatisfied constructor dependency constraints', () => { // some frameworks error if there are no assertions assert.equal(true, true); diff --git a/packages/utils/tests/eslint-utils/rule-tester/RuleTester.test.ts b/packages/utils/tests/eslint-utils/rule-tester/RuleTester.test.ts index ca8ee21e1fd..a378e7e6106 100644 --- a/packages/utils/tests/eslint-utils/rule-tester/RuleTester.test.ts +++ b/packages/utils/tests/eslint-utils/rule-tester/RuleTester.test.ts @@ -750,7 +750,7 @@ describe('RuleTester', () => { mockedDescribe.mock.lastCall?.[1](); expect(mockedIt.mock.lastCall).toMatchInlineSnapshot(` [ - "All test skipped due to unsatisfied constructor dependency constraints", + "All tests skipped due to unsatisfied constructor dependency constraints", [Function], ] `);