From bed4a9e4247ff920c8514697644ed2e3571551b4 Mon Sep 17 00:00:00 2001 From: detljh Date: Mon, 7 Jun 2021 17:25:55 +1000 Subject: [PATCH] feat(experimental-utils): moved types eslint-plugin util to experimental-utils package --- .../eslint-utils}/isUnsafeAssignment.test.ts | 57 ++++++++++++------- 1 file changed, 38 insertions(+), 19 deletions(-) rename packages/{eslint-plugin/tests/util => experimental-utils/tests/eslint-utils}/isUnsafeAssignment.test.ts (75%) diff --git a/packages/eslint-plugin/tests/util/isUnsafeAssignment.test.ts b/packages/experimental-utils/tests/eslint-utils/isUnsafeAssignment.test.ts similarity index 75% rename from packages/eslint-plugin/tests/util/isUnsafeAssignment.test.ts rename to packages/experimental-utils/tests/eslint-utils/isUnsafeAssignment.test.ts index 95780856bc3..a0ddf4518f8 100644 --- a/packages/eslint-plugin/tests/util/isUnsafeAssignment.test.ts +++ b/packages/experimental-utils/tests/eslint-utils/isUnsafeAssignment.test.ts @@ -1,9 +1,8 @@ import * as ts from 'typescript'; -import { TSESTree } from '@typescript-eslint/experimental-utils'; import { parseForESLint } from '@typescript-eslint/parser'; +import { getFixturesRootDir } from '@typescript-eslint/eslint-plugin/tests/RuleTester'; import path from 'path'; -import { getFixturesRootDir } from '../RuleTester'; -import { isUnsafeAssignment } from '../../src/util'; +import { ESLintUtils, TSESTree } from '../../src'; describe('isUnsafeAssignment', () => { const rootDir = getFixturesRootDir(); @@ -34,7 +33,7 @@ describe('isUnsafeAssignment', () => { describe('unsafe', () => { function expectTypesAre( - result: ReturnType, + result: ReturnType, checker: ts.TypeChecker, senderStr: string, receiverStr: string, @@ -52,7 +51,7 @@ describe('isUnsafeAssignment', () => { ); expectTypesAre( - isUnsafeAssignment(sender, receiver, checker), + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), checker, 'any', 'string', @@ -65,7 +64,7 @@ describe('isUnsafeAssignment', () => { ); expectTypesAre( - isUnsafeAssignment(sender, receiver, checker), + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), checker, 'Set', 'Set', @@ -78,7 +77,7 @@ describe('isUnsafeAssignment', () => { ); expectTypesAre( - isUnsafeAssignment(sender, receiver, checker), + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), checker, 'Map', 'Map', @@ -91,7 +90,7 @@ describe('isUnsafeAssignment', () => { ); expectTypesAre( - isUnsafeAssignment(sender, receiver, checker), + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), checker, 'Set', 'Set', @@ -104,7 +103,7 @@ describe('isUnsafeAssignment', () => { ); expectTypesAre( - isUnsafeAssignment(sender, receiver, checker), + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), checker, 'Set>>', 'Set>>', @@ -118,13 +117,17 @@ describe('isUnsafeAssignment', () => { 'const test: string = "";', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('non-any to a any', () => { const { sender, receiver, checker } = getTypes('const test: any = "";'); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('non-any in a generic position to a non-any', () => { @@ -132,7 +135,9 @@ describe('isUnsafeAssignment', () => { 'const test: Set = new Set();', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('non-any in a generic position to a non-any (multiple generics)', () => { @@ -140,7 +145,9 @@ describe('isUnsafeAssignment', () => { 'const test: Map = new Map();', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('non-any[] in a generic position to a non-any[]', () => { @@ -148,7 +155,9 @@ describe('isUnsafeAssignment', () => { 'const test: Set = new Set();', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('non-any in a generic position to a non-any (nested)', () => { @@ -156,7 +165,9 @@ describe('isUnsafeAssignment', () => { 'const test: Set>> = new Set>>();', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('non-any in a generic position to a any (nested)', () => { @@ -164,7 +175,9 @@ describe('isUnsafeAssignment', () => { 'const test: Set>> = new Set>>();', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('any to a unknown', () => { @@ -172,7 +185,9 @@ describe('isUnsafeAssignment', () => { 'const test: unknown = [] as any;', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('any[] in a generic position to a unknown[]', () => { @@ -180,7 +195,9 @@ describe('isUnsafeAssignment', () => { 'const test: unknown[] = [] as any[]', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); it('any in a generic position to a unknown (nested)', () => { @@ -188,7 +205,9 @@ describe('isUnsafeAssignment', () => { 'const test: Set>> = new Set>>();', ); - expect(isUnsafeAssignment(sender, receiver, checker)).toBeFalsy(); + expect( + ESLintUtils.isUnsafeAssignment(sender, receiver, checker), + ).toBeFalsy(); }); }); });