From 872ed4996378d2b387e58ffd808f225b74a529b8 Mon Sep 17 00:00:00 2001 From: Toru Nagashima Date: Tue, 9 Apr 2019 19:22:17 +0900 Subject: [PATCH] fix for review --- .../src/rules/prefer-string-starts-ends-with.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts b/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts index 5c625e0e1f5..6b3079cdfdf 100644 --- a/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts +++ b/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts @@ -367,11 +367,10 @@ export default createRule({ // foo.charAt(0) === "a" // foo[foo.length - 1] === "a" // foo.charAt(foo.length - 1) === "a" - // @ts-ignore - [[ + [String([ 'BinaryExpression > MemberExpression.left[computed=true]', 'BinaryExpression > CallExpression.left > MemberExpression.callee[property.name="charAt"][computed=false]', - ]](node: TSESTree.MemberExpression): void { + ])](node: TSESTree.MemberExpression): void { let parentNode = node.parent!; let indexNode: TSESTree.Node | null = null; if (parentNode.type === 'CallExpression') { @@ -532,11 +531,10 @@ export default createRule({ // foo.substring(0, 3) === 'bar' // foo.substring(foo.length - 3) === 'bar' // foo.substring(foo.length - 3, foo.length) === 'bar' - // @ts-ignore - [[ + [String([ 'CallExpression > MemberExpression.callee[property.name=slice][computed=false]', 'CallExpression > MemberExpression.callee[property.name=substring][computed=false]', - ]](node: TSESTree.MemberExpression): void { + ])](node: TSESTree.MemberExpression): void { const callNode = node.parent! as TSESTree.CallExpression; const parentNode = callNode.parent!; if (