From 763a2520bfea09c3b6252ea36bc3ff10b05eca6c Mon Sep 17 00:00:00 2001 From: Armano Date: Fri, 19 Feb 2021 11:56:17 +0100 Subject: [PATCH] fix(eslint-plugin): [no-var-requires] report when used in type assertion (#3074) --- packages/eslint-plugin/src/rules/no-var-requires.ts | 1 + .../eslint-plugin/tests/rules/no-var-requires.test.ts | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts index 6b958d47ec2..26c49cc9dd2 100644 --- a/packages/eslint-plugin/src/rules/no-var-requires.ts +++ b/packages/eslint-plugin/src/rules/no-var-requires.ts @@ -37,6 +37,7 @@ export default util.createRule({ (parent.type === AST_NODE_TYPES.VariableDeclarator || parent.type === AST_NODE_TYPES.CallExpression || parent.type === AST_NODE_TYPES.TSAsExpression || + parent.type === AST_NODE_TYPES.TSTypeAssertion || parent.type === AST_NODE_TYPES.MemberExpression) ) { context.report({ diff --git a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts index 3ae5e243154..688b010e417 100644 --- a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts +++ b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts @@ -112,6 +112,16 @@ ruleTester.run('no-var-requires', rule, { }, ], }, + { + code: "const foo = require('./foo.json');", + errors: [ + { + messageId: 'noVarReqs', + line: 1, + column: 18, + }, + ], + }, { code: "const foo: Foo = require('./foo.json').default;", errors: [